Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize XmlReaders using StreamReaders #6863

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Initialize XmlReaders using StreamReaders #6863

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afe9c97
Initialize XmlReaders with a stream that can detect encodings
benvillalobos Sep 16, 2021
858187a
Revert to simple streamreader passing into XmlReader.Create
benvillalobos Sep 16, 2021
f6028a6
initialize XmlReaders with a stream and a baseuri
benvillalobos Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Tasks/XslTransformation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ public XmlReader CreateReader(int itemPos)
{
if (XmlMode == XmlModes.XmlFile)
{
return XmlReader.Create(_data[itemPos]);
return XmlReader.Create(new StreamReader(_data[itemPos]), null, _data[itemPos]);
}
else // xmlModes.Xml
{
Expand Down Expand Up @@ -459,7 +459,7 @@ public XslCompiledTransform LoadXslt(bool useTrustedSettings)
_log.LogMessageFromResources(MessageImportance.Low, "XslTransform.UseTrustedSettings", _data);
}

xslct.Load(new XPathDocument(XmlReader.Create(_data)), settings, new XmlUrlResolver());
xslct.Load(new XPathDocument(XmlReader.Create(new StreamReader(_data), null, _data)), settings, new XmlUrlResolver());
break;
case XslModes.XsltCompiledDll:
#if FEATURE_COMPILED_XSL
Expand Down