Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution global properties for solution-based graphs #8872

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

dfederm
Copy link
Contributor

@dfederm dfederm commented Jun 12, 2023

Add solution global properties for solution-based graphs

More in the vein of #8625 and #8855. Getting sln-based graph builds to be more aligned with non-graph sln builds.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to validate that this is the full set of magic solution properties? I can't think of a great one myself.

src/Build.UnitTests/Graph/GraphLoadedFromSolution_tests.cs Outdated Show resolved Hide resolved
@dfederm
Copy link
Contributor Author

dfederm commented Jun 12, 2023

Any way to validate that this is the full set of magic solution properties? I can't think of a great one myself.

I compared binlogs, but I don't think you're talking about manual validation.

The only thing I can think of is to create a helper in SolutionProjectGenerator, but even then it uses a ProjectPropertyGroupElement while the graph code uses a ImmutableDictionary<string, string>.Builder. So extra allocation there to copy the collection or taking some Action<string, string> which also would allocate.

src/Build/Graph/GraphBuilder.cs Show resolved Hide resolved
@AR-May AR-May added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jun 13, 2023
@JanKrivanek JanKrivanek merged commit 605dde6 into dotnet:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants