Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark data for testing non-vectorised paths #1026

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Add benchmark data for testing non-vectorised paths #1026

merged 3 commits into from
Nov 12, 2019

Conversation

Gnbrkm41
Copy link
Contributor

Related: dotnet/coreclr#27798

The first commit is related to the PR mentioned above; I think it could be worth adding this even if the PR above doesn't make it in, in case there could be a similar change.

The second commit is per dotnet/corefx#39173 (comment).

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Gnbrkm41 Gnbrkm41 changed the title Add benchmark data for testing non-vectorised paths [WIP] Add benchmark data for testing non-vectorised paths Nov 12, 2019
@Gnbrkm41
Copy link
Contributor Author

I'll need to add some more cases to follow up with changed implementations.

@adamsitnik
Copy link
Member

I'll need to add some more cases to follow up with changed implementations.

Please tag me when the PR is ready to merge (I would prefer to merge 1 final PR)

@Gnbrkm41
Copy link
Contributor Author

Is the performance repo being merged into runtime or somewhere else as well? Thought this was going to stay.

@adamsitnik
Copy link
Member

adamsitnik commented Nov 12, 2019

Is the performance repo being merged into runtime or somewhere else as well?

No. It's going to stay as it is today (and this time the fact that it's a standalone repo is going to save us a lot of time an engineering effort ;) )

@Gnbrkm41
Copy link
Contributor Author

Gnbrkm41 commented Nov 12, 2019

Actually... I think this is good as-is. I was going to add a slightly longer string, thinking it would matter since I changed the implementation to process more at once; but it is covered by the current data as well. @adamsitnik should be good now.

@Gnbrkm41 Gnbrkm41 changed the title [WIP] Add benchmark data for testing non-vectorised paths Add benchmark data for testing non-vectorised paths Nov 12, 2019
@adamsitnik adamsitnik merged commit 6b0353c into dotnet:master Nov 12, 2019
@Gnbrkm41 Gnbrkm41 deleted the vectoriseReplace branch November 13, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants