-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark data for testing non-vectorised paths #1026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
I'll need to add some more cases to follow up with changed implementations. |
Please tag me when the PR is ready to merge (I would prefer to merge 1 final PR) |
Is the performance repo being merged into runtime or somewhere else as well? Thought this was going to stay. |
No. It's going to stay as it is today (and this time the fact that it's a standalone repo is going to save us a lot of time an engineering effort ;) ) |
* Add benchmark data to prevent regressions for short strings
Actually... I think this is good as-is. I was going to add a slightly longer string, thinking it would matter since I changed the implementation to process more at once; but it is covered by the current data as well. @adamsitnik should be good now. |
Related: dotnet/coreclr#27798
The first commit is related to the PR mentioned above; I think it could be worth adding this even if the PR above doesn't make it in, in case there could be a similar change.
The second commit is per dotnet/corefx#39173 (comment).