Undoing a Roslyn rename prompts a rename

[davkean]

Steps to Reproduce:

1. File -> New -> Console App (.NET Core)
2. Press F2 to rename Program -> NotProgram

-- observe that Program.cs has been renamed to NotProgram.cs --

3. In same editor, CTRL+Z to undo rename

Expected Behavior:
No prompt to rename

Actual Behavior:

User Impact:

[davkean]

/cc @jmarolf @ryzngard

Looks like both your bits arrived in master, and the above is the result.

[jmarolf]

@davkean I cannot reproduce this with the repro steps provided. Is there anything else that you did other than what you've suggested?

[davkean]

Here's a video:

[davkean]

This is going to because we conflating "renames" via dataflow with user actions.

[jmarolf]

@davkean I cannot reliably repo this today, can you provide consistent repro steps on a build we've release?

[davkean]

I mentioned early on in the rewrite that we shouldn't be using dataflow renames as an indication that the user renamed the class, any setting of ProjectItem.Name should result in this.

[jmarolf]

I think I see where I misunderstood @davkean when you said this:

Press F2 to rename Program -> NotProgram

I thought you mean't F2 in the solution explorer, I assume you actually meant F2 on the class definition, which I can repro

[jmarolf]

yeah, well need to re-write everything again...

[ocallesp]

@davkean I will investigate this issue.
This issue is related to https://youtrack.jetbrains.com/issue/RSRP-476479
e-mail thread with subject [EXTERNAL] Bogus 'You are renaming a file...`

[ocallesp]

@jmarolf @davkean I cannot repro this issue using the steps in the description. Is there any missing step ?

[davkean]

@ocallesp The "Rename File" code fix isn't showing up for me anymore, can you see it? Regardless, this will still occur when any component (such as R#) uses APIs to rename files.

[ryzngard]

This is currently blocking us from enabling this on the Roslyn side, so it shouldn't show up for CPS projects.

[davkean]

Did you remove the code fix? It was enabled at one point.

[ryzngard]

It hasn't been enabled for a long time as far as I'm aware. The PR is here dotnet/roslyn#39225