GitHub/fix programmatic rename

[ocallesp]

Fixes #5139, #5436

What this PR does:

• Updates the package version for Microsoft.VisualStudio.LanguageServices and Microsoft.CodeAnalysis to use the new Roslyn API RenameDocumentAsync and UpdateSolutionAsync.
• replaces Renamer.cs with RenamerProjectTreeActionHandlers.cs

Brief description of the changes:
The new Roslyn API does much of the work done in Renamer.cs like check if there are symbol to rename, rename symbols, and notify to other VS features. This helps dotnet Project System to move code to Roslyn and delete Renamer.cs.

Part of the code of Renamer.cs was moved RenamerProjectTreeActionHandler to be executed before CPS and before the file rename. At this point the api RenameDocumentAsync can get old document and can also check if the file rename is programmatic or not.

RenamerProjectTreeActionHandler does in chronological order:

1. Check if programmatic or user rename.
2. RenameDocumentAsync produces the actions.
3. Check if actions are feasible.
4. Rename file (remove old document and add new document)
5. We prompt to rename symbols
6. Wait for Language Service to see the rename (HandleRename)
7. Execute the actions UpdateSolutionAsync

What is missing:

• Fix Unit tests. This will be done after the code review.

Future work:

• A new API is needed to have a cleaner mechanism to synchronize with Language Service.
  Add an API that lets consumers wait on language service to be up-to-date with a given project version #3425

• The API RenameDocumentAsync can generate actions to update the namespace
  according to the logic folders.
  Moving a file in the project should offer to move the type #1035

Microsoft Reviewers: Open in CodeFlow

[davidwengier]

How did you work around the CreatePkgDef issue?

[ocallesp]

How did you work around the CreatePkgDef issue?
Can you elaborate more on this ? I see CreatePkgDef is an utility that creates a .pkgdef file.
Do you mean when renaming the .pkgdef file ?

[davidwengier]

When we talked earlier in the week, updating Microsoft.VisualStudio.Threading caused a build error with CreatePkgDef I thought. If that has gone away, thats great!

[davkean]

As we spoke offline, we played around this and we discovered the following issues:

1. If I rename a item just by case say from 'foo.cs' -> 'Foo.cs', I get:

---------------------------
Microsoft Visual Studio
---------------------------
Sequence contains no elements
---------------------------
OK   
---------------------------

2. If I rename a item when the file name doesn't match the name of type, I get:

---------------------------
Microsoft Visual Studio
---------------------------
Sequence contains no elements
---------------------------
OK   
---------------------------

3. If I rename a file to include characters that not valid name characters (such as a space), we actually go ahead and try to rename it to include that

[ryzngard]

As we spoke offline, we played around this and we discovered the following issues:

1. If I rename a item just by case say from 'foo.cs' -> 'Foo.cs', I get:

---------------------------
Microsoft Visual Studio
---------------------------
Sequence contains no elements
---------------------------
OK   
---------------------------

1. If I rename a item when the file name doesn't match the name of type, I get:

---------------------------
Microsoft Visual Studio
---------------------------
Sequence contains no elements
---------------------------
OK   
---------------------------

1. If I rename a file to include characters that not valid name characters (such as a space), we actually go ahead and try to rename it to include that

1. is expected, it behaves the same as inline rename + file rename behavior. If we should change this let's discuss.

2. Seems correct right? We don't want to update the type name to the new name unless it already matched?

3. Seems like a good candidate for returning an error for GetErrors() on the action

[davkean]

The errors are not expected, we should be handling this correctly and not failing the rename of the file itself which we are doing.

[ryzngard]

Not sure I follow, but may be missing context. The API isn't returning errors, is it errors that happen because an empty actionset is returned?

[davkean]

I just grabbed his branch, installed it and started playing around with the behavior, we show dialogs with those errors when I perform those actions. I'm not referring to to what the API is returning.