Move IVsHierarchyRefactorNotify notifications to Roslyn

[davkean]

Also fixes: #1422.

We are notifying projects of renames in the workspace in response to a user renaming a file with a type with the same name, whereas legacy uses CodeModel from Roslyn which does it automatically. We do this so that XAML, RESX and other type consuming things can be notified and updated with the new names.

We should unify this logic into a single service and have both us and CodeModel call it, the lines in particular are this: https://github.com/dotnet/roslyn/blob/master/src/VisualStudio/Core/Impl/CodeModel/AbstractCodeModelService.cs#L498-L513.

• Create a new service in Roslyn that wraps the above lines
• Change AbstractCodeModelService to call it
• Provide an API that we can use to consume it

[davkean]

This will also fix #1422 because this code would also dismiss the rename tracking (as you can see it already does in CodeModel).

[davkean]

@ocallesp This might a nice one to bite off, I can probably walk you through doing it during our 1 on 1.

[drewnoakes]

in response to a user renaming a class with a type with the same name

Do you mean "in response to a user renaming a class file with a type with the same name"

[davkean]

Yes.

[jmarolf]

The reason we didn't do tbis was that the CodeModel service is not cancelable so if a user begins a symbol rename and wants to cancel it they either need to wait or force the process to stop in task manager.

[jmarolf]

Roslyn's internal notification service is cancelable (the one they use for inline rename) but it is not exposed anywhere publicly. If you can get the roslyn team to expose some kind of cancelable api I would love to not need this code.

[davkean]

That's what this bug is tracking.

[jmarolf]

@davkean got it, just didn't see cancellation called out as the blocker. Thanks for filing this :)

[jmarolf]

My hope is that when this is merged: dotnet/roslyn#38488

We could just move all the rename logic over to roslyn itself since they are the real authority on what symbol rename should do. Us needing to re-implement everything like roslyn does is not an ideal long-term solution