Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for NuGetRestorer #3027

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Conversation

natidea
Copy link
Contributor

@natidea natidea commented Dec 6, 2017

Add logging for NuGetRestorer to capture information sent to NuGet during nomination

Customer scenario

To assist investigations of problems in interactions between project-system and NuGet, add logging to specify what information is sent. Users can turn on logging with existing set PROJECTSYSTEM_PROJECTOUTPUTPANEENABLED=1 flag

Risk and Performance impact

None, only active when debugging flag is on

/cc @dotnet/project-system

@Pilchie
Copy link
Member

Pilchie commented Dec 7, 2017

BTW - What determines if this log is enabled? Is there a way for customers to collect our logs when things go wrong?

@davkean
Copy link
Member

davkean commented Dec 7, 2017

Enabled by default in DEBUG builds, otherwise, a new category shows up in the Output window when environment is set PROJECTSYSTEM_PROJECTOUTPUTPANEENABLED=1

@natidea natidea merged commit 6d0159e into dotnet:master Dec 7, 2017
@natidea natidea deleted the nominateLogging branch December 7, 2017 22:19
@nkolev92
Copy link
Contributor

nkolev92 commented Dec 7, 2017

This is amazing.
Thanks @natidea
//cc @rrelyea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants