Make IApplyChangesToWorkspaceContext async #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class needs to be made async, which prevents lock from being used in async methods. It does not need to be thread-safe as the only consumer of it, WorkspaceContextHostInstance, prevents overlap.
In preparation of making IWorkspaceProjectContext async, plumb through async in ApplyChangesToWorkspaceContext. Handlers will come next.
drewnoakes
approved these changes
Oct 29, 2018
davidwengier
approved these changes
Oct 29, 2018
jmarolf
approved these changes
Oct 29, 2018
|
@dotnet-bot retest windows_release please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes #4187, so just review 79d7b4a.
In preparation of making IWorkspaceProjectContext async, plumb through async in ApplyChangesToWorkspaceContext. Handlers will come next.