-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the project system to depend on the latest version of Roslyn #4312
Upgrade the project system to depend on the latest version of Roslyn #4312
Conversation
This updated to [this](dotnet/roslyn@170d0bb) commit of roslyn. This forces us to bring along several other VS dependencis. NOTE: Async package made a breaking change forcing 3 tests to be disabled
....VisualStudio.ProjectSystem.CSharp.VS.UnitTests/Packaging/CSharpProjectSystemPackageTests.cs
Show resolved
Hide resolved
Has this been inserted into Preview 2, if so, which build? If not, we can't merge this. |
No Roslyn is currently working on that. Unlikely to happen before Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@davkean I upgraded Roslyn to a build contains the new |
ForegroundWorkspaceProjectContext is known a issue in master, and you can ignore it. It's already been fixed. |
NOTE: this PR #4318 also depends on this getting merged. |
Actually this Roslyn package isn't new enough to contain my changes, and I also need a new CPS package for that PR, so was going to tackle the integration as the last step. |
Fair enough. Once Roslyn insertion into Preview 2 we can take literally the newest package they have in master so that's not a problem. Is the CPS package that we would need to consume published? |
Yep, it is (>= |
The CPS change we need has been inserted to d16.0stg and a new package is on MyGet. |
We finally completed the first roslyn insertion for preview 2. Could you update roslyn to 2.11.0-beta2-63529-05 to match the version and merge this? |
@dotnet/project-system this is safe to merge now as the equivalent roslyn bits are in d16.0stg. Once things are green I am going to merge this. |
This updated to this commit of roslyn. This forces us to bring along several other VS dependencis.
NOTE: Async package made a breaking change forcing 3 tests to be disabled