Add an implemention of IActiveWorkspaceProjectContext for new language service #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This delegates onto the active config's implementation.
This ensures that the project is loaded before project load has completed. This brings back the original experience of the previous language-service integration.
🎉 Congratulations 🎉 |
davidwengier
approved these changes
Dec 13, 2018
drewnoakes
reviewed
Dec 13, 2018
...ft.VisualStudio.ProjectSystem.Managed/ProjectSystem/LanguageServices/WorkspaceContextHost.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an implemention IActiveWorkspaceProjectContext for the new language service integration
Ensure that we've initialized the language service before project load has completed
This is the last of the changes needed to make the language-service rewrite work.