-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass through RootNamespace to language-service #4432
Conversation
...rojectSystem.Managed/ProjectSystem/LanguageServices/Handlers/ProjectPropertiesItemHandler.cs
Outdated
Show resolved
Hide resolved
I'm trying to test this locally, but it seems the new code in update: I'm not sure how this works, but debugging |
RootNamespace comes from both. This is untested yet, I'll look this morning. |
@davkean Any update on this? |
Introduce a new rule; LanguageService.xaml that lets us pass through properties to the language-service without needing to write any additional code - similar to NuGutRestore.xaml.
I had a bug where the format string I was passing the logger was wrong, after I fixed this - this worked for me. |
I tried to build and deploy from latest source again, still couldn't get this to work. Same behavior as I mentioned before, when opening a solution, "roonamespace" property is part of the project change of |
RootNamespace will be a part of both rules. You need launch using Launch.cmd or F5 from our solution for the new rules to take effect. If you don't do this, the new rule will not be picked up. |
Introduce a new rule; LanguageService.xaml that lets us pass through properties to the language-service, such as RootNamespace, without needing to write any additional code - similar to NuGutRestore.xaml.