Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through RootNamespace to language-service #4432

Merged
merged 3 commits into from
Jan 22, 2019

Conversation

davkean
Copy link
Member

@davkean davkean commented Jan 7, 2019

Introduce a new rule; LanguageService.xaml that lets us pass through properties to the language-service, such as RootNamespace, without needing to write any additional code - similar to NuGutRestore.xaml.

@davkean davkean requested a review from a team as a code owner January 7, 2019 05:02
@genlu
Copy link
Member

genlu commented Jan 7, 2019

I'm trying to test this locally, but it seems the new code in ProjectPropertiesItemHandler isn't called though.

update: I'm not sure how this works, but debugging ApplyChangesToWorkspaceContext.ProcessProjectEvaluationHandlersAsync shows that the "rootnamespace" property comes in as part of ConfigurationGeneral instead of languageService

@davkean
Copy link
Member Author

davkean commented Jan 7, 2019

RootNamespace comes from both. This is untested yet, I'll look this morning.

@genlu
Copy link
Member

genlu commented Jan 16, 2019

@davkean Any update on this?

Introduce a new rule; LanguageService.xaml that lets us pass through properties to the language-service without needing to write any additional code - similar to NuGutRestore.xaml.
@davkean davkean changed the title [WIP] Pass through RootNamespace to language-service Pass through RootNamespace to language-service Jan 22, 2019
@davkean
Copy link
Member Author

davkean commented Jan 22, 2019

I had a bug where the format string I was passing the logger was wrong, after I fixed this - this worked for me.

@davkean davkean merged commit 9863bd9 into dotnet:master Jan 22, 2019
@genlu
Copy link
Member

genlu commented Jan 24, 2019

I tried to build and deploy from latest source again, still couldn't get this to work. Same behavior as I mentioned before, when opening a solution, "roonamespace" property is part of the project change of ConfigurationGeneral evaluation rule, not LanguageService. Did I miss anything?

@davkean
Copy link
Member Author

davkean commented Jan 24, 2019

RootNamespace will be a part of both rules.

You need launch using Launch.cmd or F5 from our solution for the new rules to take effect. If you don't do this, the new rule will not be picked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants