Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder properties on Application page #7038

Merged

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Mar 23, 2021

Historically in legacy projects, the Assembly Name and Default Namespace properties were manually kept in sync with the project by the user.

With SDK-style projects, it's more common to go with the default behaviour of picking up the MSBuildProjectName property, which is computed from the project's file name.

Given these properties are far less likely to be user edited, we move them further down the UI, allowing more commonly modified properties to rise to the top.

Before After
image image
Microsoft Reviewers: Open in CodeFlow

@drewnoakes drewnoakes added the Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner label Mar 23, 2021
@drewnoakes drewnoakes added this to the 16.10 milestone Mar 23, 2021
@drewnoakes drewnoakes requested a review from a team as a code owner March 23, 2021 02:34
Copy link
Contributor

@tmeschter tmeschter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence about whether Output Type or Target Framework should go first, but either is an improvement.

@drewnoakes
Copy link
Member Author

I'm on the fence about whether Output Type or Target Framework should go first, but either is an improvement.

Yes I also contemplated this. Once we get telemetry around the frequency of property updates, we can revisit ordering using actual data to inform these decisions.

Copy link
Contributor

@jjmew jjmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@drewnoakes
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Historically in legacy projects, the Assembly Name and Default Namespace properties were manually kept in sync with the project by the user.

With SDK-style projects, it's more common to go with the default behaviour of picking up the MSBuildProjectName property, which is computed from the project's file name.

Given these properties are far less likely to be user edited, we move them further down the UI, allowing more commonly modified properties to rise to the top.
@drewnoakes drewnoakes force-pushed the reorder-application-page-properties branch from 27e4a5e to 4112be3 Compare March 24, 2021 05:04
@drewnoakes drewnoakes merged commit e7a8c2d into dotnet:main Mar 24, 2021
@drewnoakes drewnoakes deleted the reorder-application-page-properties branch March 24, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants