Add pre/post build events to the Build page #7119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the interception code for pre/post build event properties only handled requests for the _evaluated_ value of these properties. For the new Project Properties UI we need both the evaluated _and_ unevaluated values. Also previously, requests for the evaluated property value were actually returning the unevaluated property value. This commit adds proper support for both kinds of value.
drewnoakes
added
Feature-Rules/Properties
Feature-Project-Properties-Designer
ghost
added
the
melytc
reviewed
Apr 13, 2021
| // meaning that the properties had access to a full range of property values for use in their | ||
| // bodies. | ||
| // | ||
| // Is SDK projects, it's not possible to define a property in the project after the common |
There was a problem hiding this comment.
Is SDK project ...
Do you mean "In SDK projects"?
melytc
approved these changes
Apr 13, 2021
drewnoakes
force-pushed
the
fix-5953-build-events
branch
from
a25a97f to
9bc3629
Compare
drewnoakes
added
auto-merge
32 tasks
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5953
Add build event interception support for unevaluated value. Previously, the interception code for pre/post build event properties only handled requests for the evaluated value of these properties. For the new Project Properties UI we need both the evaluated and unevaluated values.
Also previously, requests for the evaluated property value were actually returning the unevaluated property value.
Document use of properties/tasks for pre/post build events.
Adds entries to the Build page for events.
Produces:
Microsoft Reviewers: Open in CodeFlow