Pass TargetRefPath to Roslyn language service #7444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiYanni
approved these changes
Jul 29, 2021
drewnoakes
approved these changes
Jul 29, 2021
drewnoakes
changed the title
|
@ocallesp the Roslyn side cannot proceed until this ships in a public preview. There is no harm in merging this prior to changes from the other teams (it will pass a value to Roslyn which is ignored, and then later we can start to use it). |
|
@sharwell I'll merge this in and it should insert into VS main overnight. Is there any chance we might get this into 17.0 for preview 4? It'd be great to move the |
ghost
added this to the
|
I can merge to a -vs-deps branch for 17.0 targeting. |
MiYanni
added a commit
to MiYanni/project-system
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes part of the issue AB#1361354
The other part of the fix is in dotnet/roslyn#55244
Microsoft Reviewers: Open in CodeFlow