Export initial rules subscriptions #9561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current DTBB design in CPS is subscription based. As new subscriptions are processed, it leads to the cancellation or requeuing of builds, which can sometimes result in builds being in an invalid state. To address this issue, we've recently defined new MEF metadata in CPS, that take rule name as input to pre-identify design time build targets subscriptions to minimize the need for repeated build cancellations. This is also applicable to C# DevKit, where the logs indicate numerous cancellations. |
lifengl
reviewed
Oct 16, 2024
...osoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Setup/SetupComponentProvider.cs
Show resolved
Hide resolved
drewnoakes
approved these changes
Oct 24, 2024
drewnoakes
added
Tenet-Performance
drewnoakes
added a commit
to drewnoakes/project-system
that referenced
this pull request
Oct 25, 2024
Two recent PRs merged and caused a simple build break, which is fixed here. - dotnet#9561 - dotnet#9552
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow