Use new GetProjectDirectory method to reduce string allocations #9603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
added
Tenet-Performance
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
That insertion has now completed. |
drewnoakes
force-pushed
the
project-dir-allocations
branch
from
a9397bf to
10f917a
Compare
drewnoakes
force-pushed
the
project-dir-allocations
branch
from
9063c6a to
12377af
Compare
| @@ -894,7 +894,7 @@ internal async Task<string> GetLaunchSettingsFilePathNoCacheAsync() | |||
| // see: https://github.com/dotnet/project-system/issues/2316. | |||
|
|
|||
| // Default to the project directory if we're not able to get the AppDesigner folder. | |||
| string folder = Path.GetDirectoryName(_commonProjectServices.Project.FullPath); | |||
| string folder = _commonProjectServices.Project.GetProjectDirectory(); | |||
There was a problem hiding this comment.
Does the new GetProjectDirectory() from CPS works cross-platform?
There was a problem hiding this comment.
Yes, it's in the host-agnostic layer so is available outside of VS too.
The CPS PRs were:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids calling
Path.GetDirectoryNamein a bunch of places, which will allocate a new string for each call. The new extension method in CPS provides a singleton string for the project.Needs https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/595076 or newer to insert before being merged.
Microsoft Reviewers: Open in CodeFlow