-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PrunePackageReference support in project-system #9610
Merged
drewnoakes
merged 5 commits into
dotnet:main
from
nkolev92:dev-nkolev92-AddPrunePackageReferenceSupport
Dec 5, 2024
Merged
Add PrunePackageReference support in project-system #9610
drewnoakes
merged 5 commits into
dotnet:main
from
nkolev92:dev-nkolev92-AddPrunePackageReferenceSupport
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out by @zivkan, we need a stub for the new DTB Lines 424 to 428 in 5983ea9
|
drewnoakes
reviewed
Dec 5, 2024
...t.VisualStudio.ProjectSystem.Managed/ProjectSystem/Rules/CollectedPrunePackageReference.xaml
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Dec 5, 2024
...rojectSystem.Managed.UnitTests/ProjectSystem/PackageRestore/Snapshots/RestoreBuilderTests.cs
Outdated
Show resolved
Hide resolved
drewnoakes
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design at https://github.com/NuGet/Home/blob/dev/accepted/2024/prune-package-reference.md.
This adds support for
PrunePackageReference
with aVersion
attribute and theRestoreEnablePackagePruning
property.I know in the past we've had to do certain things to get CDK working. cc @tmeschter
Microsoft Reviewers: Open in CodeFlow