Make TagHelper & Razor comments locatable at design time. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a step to full fidelity verification that does a `LocateOwner` at every source location. If we find a `null` owner we build a snippet with a detailed response to enable us to diagnose the problem. Addresses dotnet/aspnetcore#7718
NTaylorMullen
commented
Feb 19, 2019
| { | ||
| tokens.Add(OpenAngle); | ||
| } | ||
| if (Bang != null) |
There was a problem hiding this comment.
This had a bang still which was interesting (since a TagHelper can't have one). But left it here so it maintains a direct copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocateOwnerat every source location. If we find anullowner we build a snippet with a detailed response to enable us to diagnose the problem.How the error looks when things are broken:
Addresses dotnet/aspnetcore#7718