-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blazor] Remove blazor script check #8744
Conversation
also helps if you have to have a specific script for a specific page/component and don't want to load it everywhere, i.e. putting it in |
/AzurePipelines run razor-tooling-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
@chsienki can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my interest/knowledge, should this be gated by a razor version or TFM check or something? I worry that someone will open a project in VS that targets an old SDK, not get warnings about their script tags, but then when they do a command line/CI build they will. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too worried about the warning difference, but I'll ping @jaredpar for his thoughts/awareness as well.
Thanks for the review folks! |
Summary of the changes
script
tag inside a Razor file.Fixes:
#8743