Add Unit Tests

dotnet · Nov 28, 2024 · c1fafcb · c1fafcb
1 parent e734fb1
commit c1fafcb
Show file tree

Hide file tree

Showing 8 changed files with 247 additions and 1 deletion.
diff --git a/...SourceGenerator.UnitTests/Resources/SingleString_NoWarnsCSharpAsync/Resources.Designer.cs b/...SourceGenerator.UnitTests/Resources/SingleString_NoWarnsCSharpAsync/Resources.Designer.cs
diff --git a/...enerator.UnitTests/Resources/SingleString_NoWarnsCSharpAsync_CS1591/Resources.Designer.cs b/...enerator.UnitTests/Resources/SingleString_NoWarnsCSharpAsync_CS1591/Resources.Designer.cs
diff --git a/....UnitTests/Resources/SingleString_NoWarnsCSharpAsync_CS1591_IDE0010/Resources.Designer.cs b/....UnitTests/Resources/SingleString_NoWarnsCSharpAsync_CS1591_IDE0010/Resources.Designer.cs
diff --git a/...eGenerator.UnitTests/Resources/SingleString_NoWarnsVisualBasicAsync/Resources.Designer.vb b/...eGenerator.UnitTests/Resources/SingleString_NoWarnsVisualBasicAsync/Resources.Designer.vb
diff --git a/...tor.UnitTests/Resources/SingleString_NoWarnsVisualBasicAsync_CS1591/Resources.Designer.vb b/...tor.UnitTests/Resources/SingleString_NoWarnsVisualBasicAsync_CS1591/Resources.Designer.vb
diff --git a/...Tests/Resources/SingleString_NoWarnsVisualBasicAsync_CS1591_IDE0010/Resources.Designer.vb b/...Tests/Resources/SingleString_NoWarnsVisualBasicAsync_CS1591_IDE0010/Resources.Designer.vb
diff --git a/...ourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests/ResxGeneratorTests.cs b/...ourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests/ResxGeneratorTests.cs
@@ -736,6 +736,74 @@ public async Task SingleString_PublicVisualBasicAsync(bool publicResource)
 
 [/0/Resources.resx]
 build_metadata.AdditionalFiles.Public = {(publicResource ? "true" : "false")}
+"),
+                    },
+                },
+            }.AddGeneratedSources().RunAsync();
+        }
+
+        [Theory]
+        [InlineData("")]
+        [InlineData("CS1591")]
+        [InlineData("CS1591, IDE0010")]
+        [InlineData(" , CS1591, IDE0010 ")]
+        public async Task SingleString_NoWarnsCSharpAsync(string noWarns)
+        {
+            var code = ResxHeader
+                + @"  <data name=""Name"" xml:space=""preserve"">
+    <value>value</value>
+    <comment>comment</comment>
+  </data>"
+                + ResxFooter;
+
+            var id = string.Join("_", noWarns.Replace(" ", "").Split(",", System.StringSplitOptions.TrimEntries | System.StringSplitOptions.RemoveEmptyEntries));
+
+            await new VerifyCS.Test(identifier: id)
+            {
+                TestState =
+                {
+                    AdditionalFiles = { ("/0/Resources.resx", code) },
+                    AnalyzerConfigFiles =
+                    {
+                        ("/.globalconfig", $@"
+is_global = true
+
+[/0/Resources.resx]
+build_metadata.AdditionalFiles.NoWarns = {noWarns}
+"),
+                    },
+                },
+            }.AddGeneratedSources().RunAsync();
+        }
+
+        [Theory]
+        [InlineData("")]
+        [InlineData("CS1591")]
+        [InlineData("CS1591, IDE0010")]
+        [InlineData(" , CS1591, IDE0010 ")]
+        public async Task SingleString_NoWarnsVisualBasicAsync(string noWarns)
+        {
+            var code = ResxHeader
+                + @"  <data name=""Name"" xml:space=""preserve"">
+    <value>value</value>
+    <comment>comment</comment>
+  </data>"
+                + ResxFooter;
+
+            var id = string.Join("_", noWarns.Replace(" ", "").Split(",", System.StringSplitOptions.TrimEntries | System.StringSplitOptions.RemoveEmptyEntries));
+
+            await new VerifyVB.Test(identifier: id)
+            {
+                TestState =
+                {
+                    AdditionalFiles = { ("/0/Resources.resx", code) },
+                    AnalyzerConfigFiles =
+                    {
+                        ("/.globalconfig", $@"
+is_global = true
+
+[/0/Resources.resx]
+build_metadata.AdditionalFiles.NoWarns = {noWarns}
 "),
                     },
                 },

diff --git a/...s.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator/AbstractResxGenerator.cs b/...s.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator/AbstractResxGenerator.cs
@@ -118,7 +118,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                     var noWarns = Array.Empty<string>();
                     if (options.TryGetValue("build_metadata.AdditionalFiles.NoWarns", out var noWarnsText))
                     {
-                        noWarns = noWarnsText.Split([',', ';'], StringSplitOptions.RemoveEmptyEntries) ?? [];
+                        noWarns = noWarnsText.Split([',', ';'], StringSplitOptions.RemoveEmptyEntries).Select(i => i.Trim()).ToArray() ?? [];
                     }
 
                     return new[]