Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RSxxxx diagnostic for compilation end diagnostic descriptors without CompilationEnd custom tag #6282

Closed
mavasani opened this issue Nov 21, 2022 · 2 comments · Fixed by #6397
Closed

Add RSxxxx diagnostic for compilation end diagnostic descriptors without CompilationEnd custom tag #6282

mavasani opened this issue Nov 21, 2022 · 2 comments · Fixed by #6397
Labels
Area-Microsoft.CodeAnalysis.Analyzers Feature Request help wanted The issue is up-for-grabs, and can be claimed by commenting
Milestone
Unknown

Comments

@mavasani
Copy link
Contributor

Add a new RSxxxx diagnostic to our MS.CA.Analyzers package to flag descriptors being used to report a diagnostic that do not have the CompilationEnd custom tag: https://github.com/dotnet/roslyn/blob/440b6fc370f0ddcea68b445e183f1383c0d1bc6e/src/Compilers/Core/Portable/Diagnostic/WellKnownDiagnosticTags.cs#L56 custom tag

See dotnet/roslyn#65304 (comment) for details
@mavasani mavasani added Feature Request Area-Microsoft.CodeAnalysis.Analyzers help wanted The issue is up-for-grabs, and can be claimed by commenting labels Nov 21, 2022
@mavasani mavasani added this to the Unknown milestone Nov 21, 2022
@mavasani mavasani mentioned this issue Nov 21, 2022
Closed
@mavasani
Copy link
Contributor Author

mavasani commented Jan 2, 2023

@Youssef1313 Are you interested in taking this up? Otherwise, I can work on it. The corresponding user facing issue was again reported by a customer at https://developercommunity.visualstudio.com/t/Error-List-warnings-disappears-when-file/10235352

@Youssef1313
Copy link
Member

@mavasani Sorry, I won't be able for now as my exams start tomorrow :(

mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Jan 3, 2023
@mavasani
Add RSxxxx diagnostic for compilation end diagnostic descriptors with…
33aa19f 
…out CompilationEnd custom tag

Closes dotnet#6282
mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Jan 3, 2023
@mavasani
Add RSxxxx diagnostic for compilation end diagnostic descriptors with…
467f335 
…out CompilationEnd custom tag

Closes dotnet#6282
mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Jan 3, 2023
@mavasani
Add RSxxxx diagnostic for compilation end diagnostic descriptors with…
259d52e 
…out CompilationEnd custom tag

Closes dotnet#6282
mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Jan 3, 2023
@mavasani
Add RSxxxx diagnostic for compilation end diagnostic descriptors with…
ba41b0a 
…out CompilationEnd custom tag

Closes dotnet#6282
mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Jan 3, 2023
@mavasani
Add RSxxxx diagnostic for compilation end diagnostic descriptors with…
779d0de 
…out CompilationEnd custom tag

Closes dotnet#6282
mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Jan 3, 2023
@mavasani
Add RSxxxx diagnostic for compilation end diagnostic descriptors with…
2a19c5b 
…out CompilationEnd custom tag

Closes dotnet#6282
@mavasani mavasani mentioned this issue Jan 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Microsoft.CodeAnalysis.Analyzers Feature Request help wanted The issue is up-for-grabs, and can be claimed by commenting
Projects
None yet
Milestone
Unknown
2 participants
@mavasani @Youssef1313