Hopefully fixed the bug. #2710
Merged
Hopefully fixed the bug. #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
reviewed
Jul 29, 2019
| @@ -179,7 +179,7 @@ public override void Initialize(AnalysisContext context) | |||
| operationAnalysisContext => | |||
| { | |||
| IArrayInitializerOperation arrayInitializerOperation = (IArrayInitializerOperation)operationAnalysisContext.Operation; | |||
| if (sourceInfoSymbolMap.IsSourceConstantArrayOfType(arrayInitializerOperation.Parent.Type as IArrayTypeSymbol)) | |||
| if (sourceInfoSymbolMap.IsSourceConstantArrayOfType(arrayInitializerOperation.GetAncestor<IArrayCreationOperation>(OperationKind.ArrayCreation).Type as IArrayTypeSymbol)) | |||
There was a problem hiding this comment.
Can we be even more defensive and handle GetAncestor returning null gracefully by using “?.Type”?
mavasani
reviewed
Jul 29, 2019
| @@ -343,10 +343,12 @@ public override TaintedDataAbstractValue VisitArrayInitializer(IArrayInitializer | |||
| result = TaintedDataAbstractValue.MergeTainted(taintedAbstractValues); | |||
| } | |||
|
|
|||
| if (this.DataFlowAnalysisContext.SourceInfos.IsSourceConstantArrayOfType(operation.Parent.Type as IArrayTypeSymbol) | |||
| IArrayCreationOperation arrayCreationOperation = operation.GetAncestor<IArrayCreationOperation>(OperationKind.ArrayCreation); | |||
| IArrayTypeSymbol arrayTypeSymbol = arrayCreationOperation.Type as IArrayTypeSymbol; | |||
There was a problem hiding this comment.
Same here. I would handle null value return by GetAncestor and also null check before invoking IsSourceConstantArrayOfType (unless that method handles null input).
mavasani
approved these changes
Jul 29, 2019
dotpaul
reviewed
Jul 29, 2019
| @@ -292,6 +292,26 @@ public void CreateEncryptor(byte[] rgbKey) | |||
| GetCSharpResultAt(16, 9, 9, 22, "byte[] SymmetricAlgorithm.Key", "void TestClass.CreateEncryptor(byte[] rgbKey)", "byte[] Convert.FromBase64String(string s)", "void TestClass.TestMethod()")); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void Test_HardcodedIn2DByteArray_CreateEncryptor_Diagnostic() | |||
There was a problem hiding this comment.
Test_HardcodedIn2DByteArray_CreateEncryptor_Diagnostic [](start = 20, length = 54)
It'd be good to add a test for a jagged array (like byte[][]) also.
Is there a test case that covers the assert from #2708?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2707
#2708