Fix the bug occurring when element type of array is not INamedType. #2730
Conversation
|
I thought the assert was firing for params arrays. Were you able to repro against the roslyn-analysis repo? |
| } | ||
| }"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Not that I'm super worried about someone putting a hardcoded key in a params byte[] array, but would we treat the params array as a tainted source if someone called MethodWithArrayParameters<byte>(1, 2, 3)? If it's easy to handle, I think we should since that would count as a constant byte array. If it's not easy to handle, we should at least put a comment somewhere that SourceInfo.TaintConstantArray doesn't handle params arrays.
There was a problem hiding this comment.
This case can be handled. At the point of the invocation of MethodWithArrayParameters(1, 2, 3), it will trigger the callback of OperationKind.ArrayInitializer. A test case will be added.
No description provided.