-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new diagnostic/code fix to prompt analyzer authors to enable re… #3440
Merged
mavasani
merged 7 commits into
dotnet:master
from
mavasani:EnableReleaseTrackingDiagnostic
Mar 29, 2020
Merged
Add a new diagnostic/code fix to prompt analyzer authors to enable re… #3440
mavasani
merged 7 commits into
dotnet:master
from
mavasani:EnableReleaseTrackingDiagnostic
Mar 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lease tracking analyzers Also updated the documentation accordingly.
sharwell
reviewed
Mar 27, 2020
nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.targets
Show resolved
Hide resolved
sharwell
reviewed
Mar 27, 2020
src/Microsoft.CodeAnalysis.Analyzers/UnitTests/MetaAnalyzers/ReleaseTrackingAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Mar 27, 2020
src/Microsoft.CodeAnalysis.Analyzers/UnitTests/MetaAnalyzers/ReleaseTrackingAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3440 +/- ##
========================================
Coverage 95.27% 95.27%
========================================
Files 1004 1004
Lines 230592 230732 +140
Branches 14887 14899 +12
========================================
+ Hits 219690 219827 +137
- Misses 9255 9259 +4
+ Partials 1647 1646 -1 |
Note to self: Need to fix a new RS diagnostic once #3444 goes in. |
sharwell
reviewed
Mar 28, 2020
src/Microsoft.CodeAnalysis.Analyzers/UnitTests/MetaAnalyzers/ReleaseTrackingAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
@sharwell Any further feedback? |
mavasani
commented
Mar 29, 2020
src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lease tracking analyzers
Also updated the documentation accordingly.