Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2.9.x into master #3855

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Merge 2.9.x into master #3855

merged 5 commits into from
Jul 14, 2020

Conversation

mavasani
Copy link
Contributor

FYI @dotpaul

@mavasani mavasani requested a review from dotpaul July 14, 2020 19:43
@mavasani mavasani requested a review from a team as a code owner July 14, 2020 19:43
var csharpTest = new VerifyCS.Test
{
ReferenceAssemblies = AdditionalMetadataReferences
.DefaultWithNewtonsoftJson12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotpaul This requires the update for the method to take the NewtonsoftJson version.

Copy link
Contributor

@dotpaul dotpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #3855 into master will decrease coverage by 0.00%.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##           master    #3855      +/-   ##
==========================================
- Coverage   95.59%   95.58%   -0.01%     
==========================================
  Files        1120     1139      +19     
  Lines      248706   251063    +2357     
  Branches    14898    15055     +157     
==========================================
+ Hits       237740   239983    +2243     
- Misses       9070     9151      +81     
- Partials     1896     1929      +33     

@mavasani mavasani merged commit 303d517 into dotnet:master Jul 14, 2020
@mavasani mavasani deleted the FI_2_9_x branch July 14, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants