Update messaging fo the after merge comments #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
commented
Sep 23, 2022
| @@ -1990,7 +1990,7 @@ | |||
| <value>Starting with .NET 7 the operator '{0}' will throw when overflowing in a checked context. Wrap the expression with an 'unchecked' statement to restore the .NET 6 behavior.</value> | |||
| </data> | |||
| <data name="PreventNumericIntPtrUIntPtrBehavioralChangesTitle" xml:space="preserve"> | |||
| <value>Prevent from behavioral change</value> | |||
| <value>Prevent behavioral change</value> | |||
There was a problem hiding this comment.
Maybe better to mention that its related to the behavioral changes in IntPtr/UIntPtr, something like
Suggested change
| <value>Prevent behavioral change</value> | |
| <value>Prevent numeric IntPtr/UIntPtr behavioral changes</value> |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6178 +/- ##
==========================================
- Coverage 96.06% 96.04% -0.03%
==========================================
Files 1364 1359 -5
Lines 313730 311706 -2024
Branches 10125 10046 -79
==========================================
- Hits 301379 299369 -2010
+ Misses 9932 9924 -8
+ Partials 2419 2413 -6 |
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Show resolved
Hide resolved
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.cs.xlf
Outdated
Show resolved
Hide resolved
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.cs.xlf
Show resolved
Hide resolved
There was a problem hiding this comment.
I left some suggestions, they would need to get applied to the rest of the files.
@gewarren does my suggestion make sense, or would you word it differently?
Co-authored-by: Genevieve Warren <[email protected]>
gewarren
approved these changes
Oct 4, 2022
jeffhandley
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve messaging, addressing feedback in the PR