Support ForEachVariableStatement in stackalloc analyzer #6286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Nov 23, 2022
| @@ -71,7 +72,7 @@ static bool ShouldWarn(IOperation? op, SyntaxNode node) | |||
| foreach (IOperation child in block.Operations) | |||
| { | |||
| if (child.Syntax.SpanStart > node.SpanStart && | |||
| (child is IReturnOperation || (child is IBranchOperation branch && branch.BranchKind == BranchKind.Break))) | |||
| (child is IReturnOperation or IBranchOperation { BranchKind: BranchKind.Break })) | |||
There was a problem hiding this comment.
No behavior change here. only a minor stylish change.
Youssef1313
commented
Nov 23, 2022
| @@ -88,7 +89,7 @@ static bool ShouldWarn(IOperation? op, SyntaxNode node) | |||
| } | |||
|
|
|||
| // Warn as needed. | |||
| if (ShouldWarn(ctx.SemanticModel.GetOperationWalkingUpParentChain(ctx.Node, default), ctx.Node)) | |||
| if (ShouldWarn(ctx.SemanticModel.GetOperationWalkingUpParentChain(ctx.Node, ctx.CancellationToken), ctx.Node)) | |||
There was a problem hiding this comment.
This is an unrelated improvement.
Youssef1313
commented
Nov 23, 2022
Comment on lines
+41
to
+42
| case SyntaxKind.ForEachVariableStatement: | ||
| var foreachStatement = (CommonForEachStatementSyntax)node; |
There was a problem hiding this comment.
This is the main fix.
mavasani
approved these changes
Nov 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.