Support VB for ImmutableObjectMethodAnalyzer #6321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Dec 10, 2022
src/Microsoft.CodeAnalysis.Analyzers/Core/CodeAnalysisDiagnosticsResources.resx
Show resolved
Hide resolved
Youssef1313
force-pushed
the
immutable-analyzer
branch
from
5a6207e to
ad3be7b
Compare
Youssef1313
commented
Dec 10, 2022
Comment on lines
91
to
99
| INamedTypeSymbol? type = null; | ||
| if (invocation.Instance is not null) | ||
| { | ||
| type = invocation.Instance.Type as INamedTypeSymbol; | ||
| } | ||
| else if (invocation.TargetMethod.IsExtensionMethod && invocation.TargetMethod.Parameters is [{ Type: var parameterType }, ..]) | ||
| { | ||
| type = parameterType as INamedTypeSymbol; | ||
| } |
There was a problem hiding this comment.
@mavasani Does this logic sound correct? I'm surprised there is no property on IInvocationOperation to get this info directly (or at least I couldn't find it)
There was a problem hiding this comment.
Can you instead use
There was a problem hiding this comment.
It looks like GetReceiverType implementation is incorrect when beforeConversion is false.
firstArg.Type is always null. I'll use this extension and fix its implementation.
mavasani
approved these changes
Jan 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6321 +/- ##
==========================================
+ Coverage 96.07% 96.12% +0.04%
==========================================
Files 1367 1361 -6
Lines 315348 316084 +736
Branches 10187 10183 -4
==========================================
+ Hits 302985 303841 +856
+ Misses 9930 9814 -116
+ Partials 2433 2429 -4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write the analyzer using IOperation for easy VB support.
Also fixes #1128
@mavasani I'm not sure whether using IOperation improves performance, doesn't affect it, or make it worse, but if you think this should remain using syntax node actions, let me know and I'll add VB support using syntax node actions.