Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup UpgradeMSBuildWorkspaceAnalyzer #6324

Merged
merged 4 commits into from
Jan 3, 2023
Merged

Cleanup UpgradeMSBuildWorkspaceAnalyzer #6324

merged 4 commits into from
Jan 3, 2023

Conversation

Youssef1313
Copy link
Member

Closes #6323

@Youssef1313 Youssef1313 mentioned this pull request Dec 10, 2022
Closed
@codecov
Copy link

codecov bot commented Dec 10, 2022 •
edited
Loading

Codecov Report

Merging #6324 (c797946) into main (e378446) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head c797946 differs from pull request most recent head 47fa7f6. Consider uploading reports for the commit 47fa7f6 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6324      +/-   ##
==========================================
- Coverage   96.11%   96.07%   -0.04%     
==========================================
  Files        1361     1367       +6     
  Lines      316051   315377     -674     
  Branches    10185    10186       +1     
==========================================
- Hits       303771   303010     -761     
- Misses       9848     9936      +88     
+ Partials     2432     2431       -1

@Youssef1313 Youssef1313 marked this pull request as ready for review December 10, 2022 13:58
@Youssef1313 Youssef1313 requested a review from a team as a code owner December 10, 2022 13:58
@mavasani
Copy link
Contributor

mavasani commented Jan 3, 2023

@Youssef1313 Can you please resolve conflicts?

@mavasani mavasani enabled auto-merge January 3, 2023 15:53
@mavasani mavasani merged commit 8b6cacf into dotnet:main Jan 3, 2023
@github-actions github-actions bot added this to the vNext milestone Jan 3, 2023
@Youssef1313 Youssef1313 deleted the cleanup branch January 3, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavasani mavasani mavasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vNext
Development

Successfully merging this pull request may close these issues.

UpgradeMSBuildWorkspaceAnalyzer tests doesn't match real behavior
2 participants
@Youssef1313 @mavasani