Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some of the unused resources #6341

Merged
merged 4 commits into from
Dec 21, 2022

Conversation

Youssef1313
Copy link
Member

No description provided.

@Youssef1313 Youssef1313 requested a review from a team as a code owner December 13, 2022 11:40
@Youssef1313 Youssef1313 force-pushed the remove-unused-resources branch from aa25227 to 38831f6 Compare December 13, 2022 11:46
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #6341 (d1e2d12) into main (8a04420) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6341      +/-   ##
==========================================
- Coverage   96.10%   96.10%   -0.01%     
==========================================
  Files        1361     1361              
  Lines      316055   316055              
  Branches    10203    10203              
==========================================
- Hits       303749   303747       -2     
- Misses       9871     9875       +4     
+ Partials     2435     2433       -2     

Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I am presuming these were flagged by the unused resources analyzers that you are currently working on?

@mavasani
Copy link
Contributor

@Youssef1313 Can you please resolve merge conflicts?

@mavasani mavasani enabled auto-merge December 21, 2022 10:13
@mavasani mavasani merged commit 0ec3193 into dotnet:main Dec 21, 2022
@github-actions github-actions bot added this to the vNext milestone Dec 21, 2022
@Youssef1313 Youssef1313 deleted the remove-unused-resources branch December 21, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants