Fix false positive in the UseConcreteType analyzer. #6407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was treating assignment to a parameter within a method as though it was a argument to the containing method call, which was totally incorrect. In this analyzer, we don't care about assignments to parameters, as that doesn't influence what the analyzer is concerned with.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6407 +/- ##
=======================================
Coverage 96.14% 96.15%
=======================================
Files 1365 1365
Lines 317447 317448 +1
Branches 10263 10263
=======================================
+ Hits 305224 305228 +4
+ Misses 9787 9784 -3
Partials 2436 2436 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was treating assignment to a parameter within a method as though it was a argument to the containing method call, which was totally incorrect. In this analyzer, we don't care about assignments to parameters, as that doesn't influence what the analyzer is concerned with.