-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Move tests to target .NET 7" #6429
Conversation
Okay, let me try on #6428 |
I'm also curious about the move to .NET 8 SDK too early? There is no installer available in https://dotnet.microsoft.com/en-us/download, so we have to install nightly builds from https://github.com/dotnet/installer#table? This should at least by reflected in CONTRIBUTING.md if usage of .NET 8 SDK is kept |
Do you know which PR did that? I agree we should stay on .NET 7 |
Seems like it happened with #6409 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6429 +/- ##
=======================================
Coverage 96.14% 96.15%
=======================================
Files 1365 1365
Lines 317494 317494
Branches 10269 10269
=======================================
+ Hits 305269 305273 +4
+ Misses 9791 9787 -4
Partials 2434 2434 |
Force merging to fix the build break |
Reverts #6364 to fix the build break in the repo