Added support markdown table headers in release tracking markdown files #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6566 +/- ##
==========================================
- Coverage 96.43% 96.41% -0.02%
==========================================
Files 1372 1374 +2
Lines 320265 320382 +117
Branches 10293 10314 +21
==========================================
+ Hits 308844 308909 +65
- Misses 8967 9005 +38
- Partials 2454 2468 +14 |
mavasani
reviewed
Apr 24, 2023
| @@ -545,8 +545,12 @@ class MyAnalyzer : DiagnosticAnalyzer | |||
| [InlineData("", ReleaseTrackingHelper.TableHeaderNewOrRemovedRulesLine1 + BlankLine + "Id1 | Category1 | Warning |")] | |||
| // Missing TableHeaderLine1 in unshipped | |||
| [InlineData("", ReleaseTrackingHelper.TableTitleNewRules + BlankLine + ReleaseTrackingHelper.TableHeaderNewOrRemovedRulesLine2 + BlankLine + "Id1 | Category1 | Warning |", 2)] | |||
| // Missing TableHeaderLine1 in unshipped 2 | |||
There was a problem hiding this comment.
Instead of just having an opaque suffix 2, can you add a more detailed comment that this is testing the regex matching with xyz aspects of the entry? Same for InlineData additions below.
mavasani
approved these changes
Apr 24, 2023
mavasani
reviewed
Apr 25, 2023
src/Microsoft.CodeAnalysis.Analyzers/UnitTests/MetaAnalyzers/ReleaseTrackingAnalyzerTests.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #5866