Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for interface implementations, CA1054 #6628

Merged
merged 3 commits into from
May 25, 2023
Merged

Add check for interface implementations, CA1054 #6628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f67348
Add check for interface implementations
steveberdy May 13, 2023
6eadf1e
Add tests, checks for all interface implementations
steveberdy May 13, 2023
74f342c
Add workitem attribute
steveberdy May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...re/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/UriParametersShouldNotBeStrings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ public void Analyze(SymbolAnalysisContext context)
return;
}

if (method.IsImplementationOfAnyInterfaceMember())
{
// should not warn for implementations of interfaces that may be out of our control
return;
}

if (context.Options.IsConfiguredToSkipAnalysis(Rule, method, context.Compilation))
{
// property is excluded from analysis
Expand Down
30 changes: 30 additions & 0 deletions ...crosoft.CodeQuality.Analyzers/ApiDesignGuidelines/UriParametersShouldNotBeStringsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,36 @@ public static void Method(Uri url, Uri url2) { }

}

[Fact, WorkItem(6371, "https://github.com/dotnet/roslyn-analyzers/issues/6371")]
public async Task CA1054NoWarningsForInterfaceImplementationsAsync()
{
await VerifyCS.VerifyAnalyzerAsync(@"
using System;

public interface IUrlInterface1
{
void Method(string url);
}

public interface IUrlInterface2
{
void Method(string url);
}

public class A : IUrlInterface1, IUrlInterface2
{
public void Method(string url) // Implements IUrlInterface1, implicitly
{
}

void IUrlInterface2.Method(string url) // Implements IUrlInterface2, explicitly
{
}
}
", GetCA1054CSharpResultAt(6, 28, "url", "IUrlInterface1.Method(string)")
, GetCA1054CSharpResultAt(11, 28, "url", "IUrlInterface2.Method(string)"));
}

[Fact]
public async Task CA1054NoWarningNotPublicAsync()
{
Expand Down