Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false-flag of CompareExchange and re-usage with loops #6979

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Fix false-flag of CompareExchange and re-usage with loops #6979

merged 4 commits into from
Oct 13, 2023

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Oct 13, 2023

Fixes #6957

@jozkee jozkee requested a review from a team as a code owner October 13, 2023 02:55
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #6979 (dd6ead1) into main (8b1675a) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 97.98%.

@@           Coverage Diff            @@
##             main    #6979    +/-   ##
========================================
  Coverage   96.42%   96.43%            
========================================
  Files        1410     1410            
  Lines      335956   336154   +198     
  Branches    11095    11103     +8     
========================================
+ Hits       323956   324161   +205     
+ Misses       9207     9198     -9     
- Partials     2793     2795     +2

eiriktsarpalis
eiriktsarpalis approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jozkee!

buyaa-n
buyaa-n approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jozkee jozkee merged commit ac6c703 into dotnet:main Oct 13, 2023
11 checks passed
@jozkee jozkee deleted the ca1869_bug branch October 13, 2023 19:06
@eiriktsarpalis
Copy link
Member

@buyaa-n is there any action required to get this fix bundled with .NET 8?

@buyaa-n
Copy link
Contributor

buyaa-n commented Oct 13, 2023

I think it's same as runtime porting, let managers know and agreed with porting, create a backport with /backport to release/8.0, fill in the description, I believe then need to send out emails to tactics for approval. CC @carlossanlop

@jozkee

This comment was marked as resolved.

Sign in to view
@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions

This comment was marked as resolved.

Sign in to view
@jozkee
Copy link
Member Author

jozkee commented Oct 16, 2023

/backport to release/8.0.1xx

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx: https://github.com/dotnet/roslyn-analyzers/actions/runs/6536547982

@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buyaa-n buyaa-n buyaa-n approved these changes

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CA1869 is flagging lazily-initialized JsonSerializerOptions construction
3 participants
@jozkee @eiriktsarpalis @buyaa-n