Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA1307: Only consider equal or more accessible overloads #6998

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

david-acker
Copy link
Member

Fixes #6943

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #6998 (7c1edb4) into main (91fda6d) will increase coverage by 0.00%.
Report is 48 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6998    +/-   ##
========================================
  Coverage   96.43%   96.43%            
========================================
  Files        1412     1412            
  Lines      336432   336968   +536     
  Branches    11117    11143    +26     
========================================
+ Hits       324422   324946   +524     
- Misses       9208     9218    +10     
- Partials     2802     2804     +2     

@david-acker david-acker marked this pull request as ready for review November 1, 2023 23:30
@david-acker david-acker requested a review from a team as a code owner November 1, 2023 23:30
Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mavasani mavasani merged commit d8623b0 into dotnet:main Dec 1, 2023
11 checks passed
@david-acker david-acker deleted the bug/CA1307-overload-accessibility branch December 1, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA1307 does not respect visibility
2 participants