Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit CA1849 for IDbContextFactory.CreateDbContext #7058

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

CollinAlpert
Copy link
Contributor

Fixes #7036

@CollinAlpert CollinAlpert requested a review from a team as a code owner November 26, 2023 18:56
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Merging #7058 (096e462) into main (23bb98b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 096e462 differs from pull request most recent head f9ff90b. Consider uploading reports for the commit f9ff90b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7058   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files        1412     1412           
  Lines      336560   336569    +9     
  Branches    11119    11122    +3     
=======================================
+ Hits       324558   324568   +10     
+ Misses       9201     9199    -2     
- Partials     2801     2802    +1     

Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor nit suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants