Don't raise RS1039 when passing LocalFunctionStatementSyntax #7062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7062 +/- ##
==========================================
- Coverage 96.43% 96.43% -0.01%
==========================================
Files 1412 1412
Lines 336712 336717 +5
Branches 11142 11142
==========================================
+ Hits 324701 324705 +4
Misses 9209 9209
- Partials 2802 2803 +1 |
mavasani
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents raising RS1039 when passing a
LocalFunctionStatementSyntaxtoSemanticModel.GetDeclaredSymbol. Currently the analyzer relies on theSemanticModeloverloads and there currently is no overload forLocalFunctionStatementSyntax.dotnet/roslyn#71028 tracks an API proposal to add this.
Fixes #7061