Fix a number of issues in CA1859. #7133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7133 +/- ##
========================================
Coverage 96.44% 96.44%
========================================
Files 1413 1413
Lines 337690 338004 +314
Branches 11177 11187 +10
========================================
+ Hits 325669 325986 +317
+ Misses 9201 9200 -1
+ Partials 2820 2818 -2 |
Youssef1313
reviewed
Jan 11, 2024
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/UseConcreteTypeAnalyzer.cs
Outdated
Show resolved
Hide resolved
…UseConcreteTypeAnalyzer.cs Co-authored-by: Youssef Victor <[email protected]>
mavasani
reviewed
Jan 16, 2024
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/UseConcreteTypeAnalyzer.Collector.cs
Show resolved
Hide resolved
mavasani
approved these changes
Jan 16, 2024
|
@mavasani @Youssef1313 Could one of you please do the honor of committing this PR please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CA1859: false positive if the value is changed by await #6904. The logic didn't recognize await expressions.
Fixes CA1859 not firing in System.Net.Mail source code #7078. The logic didn't recognize indexer calls.
Fixes CA1859: Not triggering when concrete type is ImmutableArray #7127. The logic never suggested to upgrade from an interface to a struct type. There wasn't an obvious reason for that, it was an ommission on my part.