Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CA1850 Fixer not accounting for toplevel syntax nodes #7400

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

wzchua
Copy link
Contributor

@wzchua wzchua commented Sep 1, 2024

fixes #7320

@buyaa-n

@wzchua wzchua requested a review from a team as a code owner September 1, 2024 02:10
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (372f0d4) to head (ed7f54e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7400    +/-   ##
========================================
  Coverage   96.50%   96.50%            
========================================
  Files        1443     1443            
  Lines      346376   346479   +103     
  Branches    11387    11390     +3     
========================================
+ Hits       334259   334359   +100     
- Misses       9236     9238     +2     
- Partials     2881     2882     +1     

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @wzchua!

@buyaa-n buyaa-n merged commit 8c173ce into dotnet:main Oct 8, 2024
14 checks passed
@wzchua wzchua deleted the fix-toplevel-fixes-ca1850-issue7320 branch October 9, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to refactor CA1850 crashes refactoring
2 participants