Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused SymbolDisplayNameCache #7457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Delete unused SymbolDisplayNameCache #7457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions src/Utilities/Compiler/SymbolDisplayNameCache.cs
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of Microsoft.CodeAnalysis.AnalyzerUtilities NuGet package which is public API?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't see it included anywhere as part of the build (e.g.

roslyn-analyzers/src/Utilities/Compiler/Analyzer.Utilities.projitems

Line 128 in 5ed3367

<Compile Include="$(MSBuildThisFileDirectory)SymbolDisplayStringCache.cs" />
)

and I also don't see it via dotPeek when I download the most recent version of the package

image

So, it looks to me to be an orphaned file that just causes confusion. If there's something I'm missing, let me know!

This file was deleted.