Fix TestXmlReferenceResolver semantics for missing files

dotnet · Mar 8, 2021 · f971df1 · f971df1
1 parent 425dcad
commit f971df1
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/....CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/TestXmlReferenceResolver.cs b/....CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/TestXmlReferenceResolver.cs
@@ -24,7 +24,7 @@ public override int GetHashCode()
             return RuntimeHelpers.GetHashCode(this);
         }
 
-        public override Stream? OpenRead(string resolvedPath)
+        public override Stream OpenRead(string resolvedPath)
         {
             if (!XmlReferences.TryGetValue(resolvedPath, out var content))
             {
@@ -34,8 +34,13 @@ public override int GetHashCode()
             return new MemoryStream(Encoding.UTF8.GetBytes(content));
         }
 
-        public override string ResolveReference(string path, string baseFilePath)
+        public override string? ResolveReference(string path, string baseFilePath)
         {
+            if (!XmlReferences.ContainsKey(path))
+            {
+                return null;
+            }
+
             return path;
         }
     }