Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-packages should use subfolders according to NuGet API version #590

Closed
sharwell opened this issue Aug 20, 2020 · 2 comments · Fixed by #966
Closed

test-packages should use subfolders according to NuGet API version #590

sharwell opened this issue Aug 20, 2020 · 2 comments · Fixed by #966
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing fixed

Comments

@sharwell
Copy link
Member

sharwell commented Aug 20, 2020 •
edited
Loading

NuGet implementations may vary in directory layout when using the testing SDK, with different versions of NuGet not producing compatible results. To avoid this problem, one of the following two approaches would be helpful:

  1. Place packages in a subfolder of test-packages according to runtime version and/or NuGet version
  2. Detect corrupt and/or incomplete package extraction scenarios, and automatically delete the impacted package so it can be recreated

🔗 Originally reported in #583 (comment)
@sharwell sharwell added the Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing label Aug 20, 2020
@elinor-fung elinor-fung mentioned this issue Oct 26, 2021
Merged
@agocke
Copy link
Member

agocke commented Oct 28, 2021

It looks like this is causing persistent failures in the dotnet/runtime CI. Could we get a fix prioritized?

sharwell added a commit to sharwell/roslyn-sdk that referenced this issue Feb 11, 2022
@sharwell
Recover from package corruption caused by mixed NuGet versions
596196c 
Closes dotnet#590
@sharwell sharwell mentioned this issue Feb 11, 2022
Merged
@sharwell sharwell added the fixed label Feb 11, 2022
@sharwell
Copy link
Member Author

@agocke Sorry for the delay, but this should finally be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify text before other properties sharwell/roslyn-sdk
2 participants
@agocke @sharwell