Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard form for package versions #757

Closed
sharwell opened this issue Mar 9, 2021 · 0 comments · Fixed by #835
Closed

Use standard form for package versions #757

sharwell opened this issue Mar 9, 2021 · 0 comments · Fixed by #835
Assignees
@chsienki
Labels
Area-Source Generators SDK support for source generators bug

Comments

@sharwell
Copy link
Member

sharwell commented Mar 9, 2021

These package references need to use standard version properties defined in eng/Versions.props.

roslyn-sdk/src/VisualStudio.Roslyn.SDK/ComponentDebugger/Roslyn.ComponentDebugger.csproj

Lines 25 to 33 in 50e2a55

<PackageReference Include="Microsoft.VisualStudio.ProjectSystem.Managed" Version="16.8.1-beta1-1008-05" PrivateAssets="all" />
<PackageReference Include="Microsoft.VisualStudio.ProjectSystem.Managed.VS" Version="16.8.1-beta1-1008-05" PrivateAssets="all" />
<PackageReference Include="Microsoft.VisualStudio.Imaging" Version="16.7.30329.63" PrivateAssets="all" />
<PackageReference Include="Microsoft.VisualStudio.Composition" Version="16.9.6-alpha" PrivateAssets="all" />
<PackageReference Include="Microsoft.VisualStudio.Shell.Interop" Version="16.8.30705.32" PrivateAssets="all" />
<PackageReference Include="Microsoft.VisualStudio.Shell.Interop.8.0" Version="16.8.30705.32" PrivateAssets="all" />
<PackageReference Include="Microsoft.VisualStudio.Shell.Interop.15.1.DesignTime" Version="16.8.30705.32" PrivateAssets="all" />
<PackageReference Include="Microsoft.VisualStudio.Shell.Interop.15.6.DesignTime" Version="16.8.30705.32" PrivateAssets="all" />
<PackageReference Include="Microsoft.ServiceHub.Framework" Version="2.7.100" PrivateAssets="all" />

@sharwell sharwell added bug Area-Source Generators SDK support for source generators labels Mar 9, 2021
@chsienki chsienki mentioned this issue May 25, 2021
Merged
@chsienki chsienki linked a pull request May 27, 2021 that will close this issue
Use version.props for component debugger #835
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chsienki chsienki

Labels
Area-Source Generators SDK support for source generators bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use version.props for component debugger chsienki/roslyn-sdk
2 participants
@sharwell @chsienki