Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use version.props for component debugger #835

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Use version.props for component debugger #835

merged 4 commits into from
Jun 15, 2021

Conversation

chsienki
Copy link
Member

@chsienki chsienki commented May 25, 2021 •
edited by sharwell
Loading

Fixes #756
Fixes #757

@chsienki chsienki requested a review from a team as a code owner May 25, 2021 22:28
@chsienki
Copy link
Member Author

@dotnet/roslyn-sdk for review please :)

@Youssef1313
Copy link
Member

Youssef1313 commented May 27, 2021 •
edited
Loading

@chsienki I think you're marking the wrong issue here. Nope, it's actually both should be marked, but currently it's only one.

@chsienki chsienki linked an issue May 27, 2021 that may be closed by this pull request
Use standard form for package versions #757
Closed
@chsienki
Copy link
Member Author

Ping @sharwell @jmarolf for review please :)

@jmarolf jmarolf merged commit 38150ef into dotnet:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarolf jmarolf jmarolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use standard form for package versions Remove NU1603 and NU1605 suppressions
3 participants
@chsienki @Youssef1313 @jmarolf