Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding AnalzyerTest.CreateWorkspace can lead to a non-disposed workspace being created. #805

Closed
CyrusNajmabadi opened this issue Apr 29, 2021 · 0 comments · Fixed by #809
Closed

Overriding AnalzyerTest.CreateWorkspace can lead to a non-disposed workspace being created. #805

CyrusNajmabadi opened this issue Apr 29, 2021 · 0 comments · Fixed by #809
Assignees
@sharwell
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing bug fixed

Comments

@CyrusNajmabadi
Copy link
Member

Some roslyn tests need to override how the workspace is created (for example, to setup a different composition for it). However, this will lead to a workspace being created that is not properly disposed by the test. This will add a 10 second cost to each test that does this.
@sharwell sharwell added the Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing label Apr 29, 2021
@sharwell sharwell changed the title Overriding AnalzyerTest.CreateWOrkspace can lead to a non-disposed workspace being created. Overriding AnalzyerTest.CreateWorkspace can lead to a non-disposed workspace being created. Apr 29, 2021
@sharwell sharwell added the bug label Apr 29, 2021
sharwell added a commit to sharwell/roslyn-sdk that referenced this issue May 3, 2021
@sharwell
Dispose workspaces at the end of RunAsync
7c5b208 
Fixes dotnet#805
@sharwell sharwell mentioned this issue May 3, 2021
Merged
sharwell added a commit to sharwell/roslyn-sdk that referenced this issue May 3, 2021
@sharwell
Dispose workspaces at the end of RunAsync
fefb059 
Fixes dotnet#805
@sharwell sharwell added the fixed label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing bug fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dispose workspaces at the end of RunAsync sharwell/roslyn-sdk
2 participants
@sharwell @CyrusNajmabadi