Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AnalysisExclusions to TestBehaviors #298

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Apr 7, 2019

Inverting the flags allows future additions to this enumeration without invalidating code that sets the property using the object initializer syntax in tests.

Inverting the flags allows future additions to this enumeration without
invalidating code that sets the property using the object initializer
syntax in tests.
@sharwell sharwell requested a review from a team as a code owner April 7, 2019 15:01
@sharwell sharwell added the Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing label Apr 7, 2019
@jmarolf
Copy link
Contributor

jmarolf commented Apr 9, 2019

Could we call these AnalysisOptions instead of Quirks?

@sharwell
Copy link
Member Author

sharwell commented Apr 9, 2019

@jmarolf We could. The reason I somewhat like 'quirks' is these typically represent deviations from the most common (and expected) analyzer patterns. I'm hesitant to use 'AnalysisOptions' in order to avoid confusion with the upcoming 'AnalyzerOptions' concept relevant in this space, but if you don't like the current name we can find a new one.

@jmarolf
Copy link
Contributor

jmarolf commented Apr 9, 2019

I guess I feel quirks is a little presumptive. Yes this is a much more advanced option but for someone that needs to verify this sort of thing this is not a quirk. As you say AnalysisOptions is probably not good enough. Perhaps just AdditionalOptions?

@sharwell sharwell changed the title Rename AnalysisExclusions to AnalysisQuirks Rename AnalysisExclusions to TestBehaviors Apr 9, 2019
@sharwell
Copy link
Member Author

sharwell commented Apr 9, 2019

After some brainstorming we settled on TestBehaviors

Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sharwell sharwell merged commit 7091b77 into dotnet:master Apr 10, 2019
@sharwell sharwell deleted the quirks branch April 10, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants