Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a fallback ordering by diagnostic message #300

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Apr 7, 2019

This change improves deterministic test behavior for diagnostics reported with the same ID and location.

See dotnet/roslyn-analyzers#2292

This change improves deterministic test behavior for diagnostics
reported with the same ID and location.

See dotnet/roslyn-analyzers#2292
@sharwell sharwell requested a review from a team as a code owner April 7, 2019 15:05
@sharwell sharwell added the Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing label Apr 7, 2019
Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sharwell sharwell merged commit ea86bc8 into dotnet:master Apr 9, 2019
@sharwell sharwell deleted the order-by-message branch April 9, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants