Support reference assemblies #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
commented
May 28, 2019
...Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/MetadataReferences.cs
Outdated
Show resolved
Hide resolved
...Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/MetadataReferences.cs
Outdated
Show resolved
Hide resolved
...Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/MetadataReferences.cs
Outdated
Show resolved
Hide resolved
sharwell
force-pushed
the
reference-assemblies
branch
2 times, most recently
from
8f11a7e to
b25f577
Compare
Resolves dotnet#305 Fixes dotnet#232
sharwell
force-pushed
the
reference-assemblies
branch
4 times, most recently
from
09e774c to
bfd525c
Compare
sharwell
force-pushed
the
reference-assemblies
branch
from
02c7891 to
a98e27c
Compare
sharwell
commented
Oct 31, 2019
|
|
||
| public AssemblyIdentityComparer AssemblyIdentityComparer { get; } | ||
|
|
||
| public PackageIdentity? ReferenceAssemblyPackage { get; } |
There was a problem hiding this comment.
📝 PackageIdentity is a type from the NuGet API. Most NuGet-related APIs are not directly exposed by the testing library API, but this one is. This seems fine (at least for the first release of this feature) but I wanted to call it out.
...icrosoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/ReferenceAssemblies.cs
Outdated
Show resolved
Hide resolved
...icrosoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/ReferenceAssemblies.cs
Outdated
Show resolved
Hide resolved
| <PackageReference Include="NuGet.Common" Version="$(NuGetApiVersion)" PrivateAssets="compile" /> | ||
| <PackageReference Include="NuGet.Protocol" Version="$(NuGetApiVersion)" PrivateAssets="compile" /> | ||
| <PackageReference Include="NuGet.Resolver" Version="$(NuGetApiVersion)" PrivateAssets="compile" /> | ||
| <PackageReference Include="NuGet.Packaging" Version="$(NuGetApiVersion)" /> |
There was a problem hiding this comment.
📝 This package is required at compile time for test code to use PackageIdentity.
jmarolf
reviewed
Nov 1, 2019
...sting/Microsoft.CodeAnalysis.Analyzer.Testing/Microsoft.CodeAnalysis.Analyzer.Testing.csproj
Show resolved
Hide resolved
jmarolf
reviewed
Nov 1, 2019
...s.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/ReferenceAssemblies+FileSystemSemaphore.cs
Show resolved
Hide resolved
jmarolf
reviewed
Nov 1, 2019
...icrosoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/ReferenceAssemblies.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #305
Fixes #232