Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid trying to load Microsoft.VisualBasic when not necessary #388

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

sharwell
Copy link
Member

This change allows analyzer tests for C# to run on Mono.

See #237
See mono/mono#10679

This change allows analyzer tests for C# to run on Mono.

See dotnet#237
See mono/mono#10679
@sharwell sharwell requested a review from a team as a code owner September 16, 2019 22:16
@jmarolf
Copy link
Contributor

jmarolf commented Sep 17, 2019

@sharwell can we add a mono test leg to this repo to ensure we don't regress this?

@sharwell
Copy link
Member Author

@jmarolf We can add a Mono test leg, but even with that I'm not sure it would ensure no regressions. Mono does not support the API surface of net472 or netcoreapp2.2, so it is allowed to fail these tests at any time for any reason.

@sharwell
Copy link
Member Author

@jmarolf Note that I have no idea how to add a mono test leg, so we would need to get infrastructure and/or arcade support for that part.

@jmarolf
Copy link
Contributor

jmarolf commented Sep 17, 2019

@sharwell I assume @tmat encountered this issue on an arcade repo so there must be a way?

@jmarolf
Copy link
Contributor

jmarolf commented Sep 17, 2019

Mono does not support the API surface of net472 or netcoreapp2.2, so it is allowed to fail these tests at any time for any reason.

I don't understand what we are doing then. How is this not just an infinite bug tail for us?

@bradwilson
Copy link

I don't understand what we are doing then.

@sharwell is trying to make this usable for @xunit's analyzers, where Mono (on Linux/macOS) support is a hard requirement.

@sharwell
Copy link
Member Author

@bradwilson If this doesn't work, I'll take the extraction one step further to avoid having this reference in the code paths you're relying on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants